This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Try moving methods that call add_push_rule to PushRuleStore #12764
Description
Noticed in https://github.com/matrix-org/synapse/pull/12717/files#r873957164.
We seem to have two methods on the PushRulesWorkerStore which call add_push_rule. That requires write access to the push rules tables, which I think is usually reserved for the non-worker PushRuleStore. I think we should
- Move those methods to the PushRuleStore subclass
- Fixup any mypy complaints about redundant type-ignores
- Check tests pass in CI.