Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Remove unnecessary use of jquery on the recaptcha page #11308

Closed
#14672
Closed
Remove unnecessary use of jquery on the recaptcha page#11308
#14672
Labels
S-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.good first issueGood for newcomers
@dkasak

Description

@dkasak
dkasak
opened on Nov 11, 2021

Currently we use jquery for some very rudimentary operations on the recaptcha page.

synapse/synapse/res/templates/recaptcha.html

Lines 8 to 13 in 73cbb28

<script src="//code.jquery.com/jquery-1.11.2.min.js"></script>
<link rel="stylesheet" href="/_matrix/static/client/register/style.css">
<script>
function captchaDone() {
$('#registrationForm').submit();
}

This seems like overkill since they could easily be replaced by document.getElementById or document.querySelector.

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions