Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Synapse uses an unstable prefix for thirdparty application service requests #11158

@babolivier

Description

@babolivier

The appservice code has an APP_SERVICE_PREFIX constant:

APP_SERVICE_PREFIX = "/_matrix/app/unstable"

Which it then uses for any .../thirdparty/... request:

uri = "%s%s/thirdparty/%s/%s" % (
service.url,
APP_SERVICE_PREFIX,
kind,
urllib.parse.quote(protocol),
)

uri = "%s%s/thirdparty/protocol/%s" % (
service.url,
APP_SERVICE_PREFIX,
urllib.parse.quote(protocol),
)

However, the spec says that these endpoints should have the prefix /_matrix/app/v1, not /_matrix/app/unstable. This means that if an application service correctly implements the spec, Synapse will 404 when trying to contact it on these endpoints (when e.g. looking up which third-party protocol an application service uses).

Metadata

Metadata

Assignees

Labels

A-Spec-Complianceplaces where synapse does not conform to the specO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contribution

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions