This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Synapse uses an unstable prefix for thirdparty
application service requests #11158
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-Spec-Complianceplaces where synapse does not conform to the specplaces where synapse does not conform to the specO-OccasionalAffects or can be seen by some users regularly or most users rarelyAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.Blocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Bugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributionWe know exactly how to fix this issue, and would be grateful for any contribution
Description
The appservice code has an APP_SERVICE_PREFIX
constant:
synapse/synapse/appservice/api.py
Line 52 in bf72d10
APP_SERVICE_PREFIX = "/_matrix/app/unstable" |
Which it then uses for any .../thirdparty/...
request:
synapse/synapse/appservice/api.py
Lines 137 to 142 in bf72d10
uri = "%s%s/thirdparty/%s/%s" % ( | |
service.url, | |
APP_SERVICE_PREFIX, | |
kind, | |
urllib.parse.quote(protocol), | |
) |
synapse/synapse/appservice/api.py
Lines 172 to 176 in bf72d10
uri = "%s%s/thirdparty/protocol/%s" % ( | |
service.url, | |
APP_SERVICE_PREFIX, | |
urllib.parse.quote(protocol), | |
) |
However, the spec says that these endpoints should have the prefix /_matrix/app/v1
, not /_matrix/app/unstable
. This means that if an application service correctly implements the spec, Synapse will 404 when trying to contact it on these endpoints (when e.g. looking up which third-party protocol an application service uses).
Metadata
Metadata
Assignees
Labels
A-Spec-Complianceplaces where synapse does not conform to the specplaces where synapse does not conform to the specO-OccasionalAffects or can be seen by some users regularly or most users rarelyAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.Blocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Bugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributionWe know exactly how to fix this issue, and would be grateful for any contribution