Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Include bundled events when requesting relations #11087

@clokep

Description

@clokep

In order for MSC3440 to be successful it proposes being explicit about the behavior in MSC2675 that the /relations API should include the bundled relations of each returned event.

The behavior here was changed a few times:

The proposal here is to include them on the relations event. Note that #5654 includes the following:

We also do this when pulling the relation events as well, because edits of edits are not something we'd like to support here.

The code in question lies at:

# Similarly, we don't allow relations to be applied to relations, so we
# return the original relations without any aggregations on top of them
# here.
serialized_events = await self._event_serializer.serialize_events(
events, now, bundle_aggregations=False
)

Which asserts that we don't allow relations to relations, but I don't think this is accurate. If this is a problem for edits we might need to solve this a different way.

Metadata

Metadata

Assignees

Labels

A-ThreadsThreaded messagesT-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.z-p2(Deprecated Label)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions