Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Avoid re-calculating bundled aggregations for cached results #11585

@clokep

Description

@clokep

Related to #11583 -- currently when we generate a sync response we cache it for a period of time (as clients sometimes timeout and retry). Unfortunately the bundled aggregations are added during the serialization step, which occurs after caching, and is re-done even when using a cached response.

Ideally we should be calculating the bundled aggregations earlier in a different manner and the serialization methods should be synchronous.

See https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$1E_K64Dd5p6iFMS4agak62bn5JZl3Ry-6XiTXYzOmhU?via=matrix.org&via=vector.modular.im&via=envs.net for a brief conversation around this.

Metadata

Metadata

Assignees

Labels

A-ThreadsThreaded messagesT-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions