Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Synapse selects "preset": "public_chat" by default, while it should be "private_chat" #11498

@ShadowJonathan

Description

@ShadowJonathan

Description

I noticed this while looking at the spec;

While creating rooms, /createRooms recommends - for a default "preset" - to use "private_chat", recommending it to look at "visibility", which defaults to "private".

However, synapse creates public_chat rooms when given no options.

I know that the spec is only saying "should" here, but since Dendrite and Conduit also display this behaviour, it could cause confusion that a "known good" server such as Synapse is going against spec here, creating bugs in software where previously there were none.

Version information

  • Version: v1.48.0

  • Install method: Docker

  • Platform: Linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Spec-Complianceplaces where synapse does not conform to the specS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions