Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Dependency issue: Minimum ijson version to low preventing to join rooms #11438

@passw0rd123

Description

@passw0rd123

Description

Usage of use_float in ijson introduced in e81fa92 needs a minimum version of 3.1

Set version "ijson>=3.0" in https://github.com/matrix-org/synapse/blob/develop/synapse/python_dependencies.py is to low. use_float is introduced in ijson 3.1

Joining rooms is failing with the following error.

Failed to join room
Failed to send_join via any server

 synapse.federation.federation_client: [POST-352731] Failed to send_join via matrix.org
 Traceback (most recent call last):
   File "/usr/lib/python3.6/site-packages/synapse/federation/federation_client.py", line 589, in _try_destination_list
     return await callback(destination)
   File "/usr/lib/python3.6/site-packages/synapse/federation/federation_client.py", line 768, in send_request
     response = await self._do_send_join(room_version, destination, pdu)
   File "/usr/lib/python3.6/site-packages/synapse/federation/federation_client.py", line 911, in _do_send_join
     content=pdu.get_pdu_json(time_now),
   File "/usr/lib/python3.6/site-packages/synapse/federation/transport/client.py", line 314, in send_join_v2
     parser=SendJoinParser(room_version, v1_api=False),
   File "/usr/lib/python3.6/site-packages/synapse/federation/transport/client.py", line 1313, in __init__
     use_float=True,
   File "/usr/lib64/python3.6/site-packages/ijson/common.py", line 251, in items_coro
     *_items_pipeline(backend, prefix, map_type, config)
   File "/usr/lib64/python3.6/site-packages/ijson/utils.py", line 29, in chain
     f = coro_func(f, *coro_args, **coro_kwargs)
   File "/usr/lib64/python3.6/site-packages/ijson/utils.py", line 13, in wrapper
     g = func(*args, **kwargs)
   File "/usr/lib64/python3.6/site-packages/ijson/backends/yajl2_c.py", line 17, in basic_parse_basecoro
     return _yajl2.basic_parse_basecoro(target.send, **kwargs)
 TypeError: 'use_float' is an invalid keyword argument for this function

Steps to reproduce

  • join existing room or follow invite
  • Element shows th following error message

Failed to join room
Failed to send_join via any server

Solution

Updating python-ijson to version 3.1.4

Version information

  • Version: 1.47.1

  • Install method: custom self packaged

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions