Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Shared rooms API doesn't work if the worker handling the request doesn't update the user directory #10339

@Half-Shot

Description

@Half-Shot

#7785 added ^/_matrix/client/unstable/uk.half-shot.msc2666/user/shared_rooms/.*$.

We check the update_user_directory config flag when handling this API, to basically sanity check that the tables we're about to query are roughly up-to-date (users_who_share_private_rooms, users_in_public_rooms). However, if the request is handled on a different synapse worker which does not have that config flag set, then the request is wrongly refused.

I'm not sure if there is an easy way to check if another Synapse process is configured to update the user directory, or whether we should just remove the check. Another option would just be to ensure this endpoint is handled on the same worker.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions