Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Wrong type for /publicRooms limit #10304

Open
Open
Wrong type for /publicRooms limit#10304
Labels
A-Room-DirectoryA-Spec-Complianceplaces where synapse does not conform to the specP3(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patchesS-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.
@timokoesters

Description

@timokoesters
timokoesters
opened on Jul 2, 2021

According to https://spec.matrix.org/unstable/server-server-api/#get_matrixfederationv1publicrooms it should be an integer, but here it is stringified:

synapse/synapse/federation/transport/client.py

Line 425 in a7a3743

data["limit"] = str(limit)

Conduit errors when the parameter is a string.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Room-DirectoryA-Spec-Complianceplaces where synapse does not conform to the specP3(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patchesS-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions