This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Test util create_room_as is_public option is misleading #10951
Description
Defaults to True.
synapse/tests/rest/client/utils.py
Line 51 in 50022cf
Docstring says:
synapse/tests/rest/client/utils.py
Lines 65 to 67 in 50022cf
But the only use is:
synapse/tests/rest/client/utils.py
Lines 80 to 81 in 50022cf
Moreover, the CS spec says of visibility that
Rooms default to private visibility if this key is not included.
Suggest:
- Change is_public to
Optional[bool], defaultNone if is_public is False, set visibility to privateelif is_public is True, set visibility to public- else do nothing.
Could alternatively leave it as a bool and fix it to actually set visibility to public when True. That would probably require fixing a bunch of tests to explicitly set is_public: False.
Spotted by @AndrewFerr in #10930.