Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

device_unused_fallback_key_types doesn't appear in /sync until after a fallback key is uploaded #10618

@turt2live

Description

@turt2live

Description

matrix-org/matrix-spec-proposals#2732 states that a client can detect server support by looking for the device_unused_fallback_key_types field in /sync, however this field is only populated by Synapse once a fallback key is uploaded. This can leave clients looping a fallback key upload as they'll be forced to assume the fallback key support is there and that all their keys have been used, thus upload a new key, which leads to the server (possibly) not supporting it and ignoring the unknown fields, so the client syncs, doesn't see the field, uploads, repeat.

Further, clients like Element Web won't upload fallback keys for users if the server doesn't advertise this field on /sync, thus there are likely users out there missing the value of fallback keys.

Steps to reproduce

  • Be on a fresh account
  • Look for device_unused_fallback_key_types in the /sync response

Version information

  • Homeserver: localhost

If not matrix.org:

  • Version: 1.40.0

  • Install method:

  • Platform: Windows / Docker

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-MajorMajor functionality / product severely impaired, no satisfactory workaround.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions