database queries run from sentinel logcontext #15
Description
we see these warnings and errors every 60 seconds:
2021-06-08 11:04:13,388 - synapse_spamcheck_badlist.bad_list_filter - 105 - INFO - sentinel - _update_links_automaton: fetching links from table image_filter.iwf_links
2021-06-08 11:04:13,388 - synapse.storage.database - 671 - WARNING - sentinel - Starting db txn 'Fetch links from the table' from sentinel context
2021-06-08 11:04:13,388 - synapse.logging.scopecontextmanager - 73 - ERROR - sentinel - Tried to activate scope outside of loggingcontext
2021-06-08 11:04:13,404 - synapse.storage.database - 720 - WARNING - sentinel - Starting db connection from sentinel context: metrics will be lost
The problem is that the updater runs as a timed task. We don't have great support for this in the module API currently (something that also came up in the context of matrix-org/synapse#9884), so I'm going to try to update the module API to sort that out.