Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Sep 29, 2020

Bug introduced in ff91a451b

We were checking whether the nextLink param was valid, even if it wasn't provided. In that case, nextLink was None, which would clearly not be a valid URL.

This would prevent password reset and other operations if nextLink was not provided and the next_link_domain_whitelist config option was in use.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoadragon453 anoadragon453 merged commit 11523b5 into dinsic Sep 29, 2020
anoadragon453 added a commit that referenced this pull request Oct 9, 2020
…oa/freeze_rooms

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Only assert valid next_link params when provided (#65)
  Don't push if an user account has expired (#58)
  Swap method calls in RoomAccessTestCase.test_change_rules (#64)
  Make all rooms noisy by default (#60)
  Make AccessRules use the public rooms directory instead of checking a room's join rules on rule change (#63)
  Override the power levels defaults, enforce mod requirement for invites, admin requirements for unknown state events (#61)
  RoomAccessRules cleanup (#62)
  Add a config option for validating 'next_link' parameters against a domain whitelist (#8275)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants