Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

Pull in type hints for pynacl #478

@DMRobertson

Description

@DMRobertson

In my spare time (i.e. not paid Element time) I've been working to add type annotations to pynacl, see pyca/pynacl#660. This is almost done, and the maintainer is keen to include them in a new minor release, "in the next few days/weeks".

Once there's a release, we should remove pynacl from the list of imports we ignore in Sydent's mypy config. Then we should fixup any complaints. The same also holds true for signedjson and synapse.

From a quick glance, there seem to be two complaints:

  • we're adding version and alg attributes to pynacl SigningKey instances (both in Sydent and signedjson)
  • we're creating a SigningKey with a str rather than a bytes (missed in 2->3 conversion?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions