The tests are broadly good, but the problem with killing one of the servers is that they are used for the entire test run, rather than being set up for each test. I think a good alternative here is to use the sytest server implementation and then we can simulate the server "going down" by having it return e.g. a 503.

The server is restarted at the end. Does the sytest server implementation emulate users actions such as joining rooms and uploading keys? Otherwise this test requires a lot of mocking.

Does the sytest server implementation emulate users actions such as joining rooms and uploading keys? Otherwise this test requires a lot of mocking.

Yup, look in test/50federation/ which all use the perl sytest federation thing.

I've changed it over to the sytest federation server