Route pagination requests to client reader #628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Jun 24, 2019
| @@ -352,3 +352,39 @@ | |||
| }) | |||
| }); | |||
| }; | |||
|
|
|||
|
|
|||
| test "/messages does not require a from param", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
right now, the fact that synapse doesn't return a 400 when this happens is a synapse bug. If we want to go the other way, it'll need an MSC defining what it means to not give a from param...
There was a problem hiding this comment.
Ugh. Ok, I just wanted a regression test but it doesn't seem obvious to me we should support not supplying a from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.