Add tests for reading account data #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Dec 18, 2018
| @@ -41,6 +42,42 @@ sub matrix_add_room_account_data | |||
| ); | |||
| } | |||
|
|
|||
| =head2 matrix_get_account_data | |||
|
|
|||
| matrix_get_account_data( $user, $type, $content )->get; | |||
There was a problem hiding this comment.
why does this have a ->get?
There was a problem hiding this comment.
copy/paste. I guess it's not needed?
There was a problem hiding this comment.
looks like the other functions here also have it...
There was a problem hiding this comment.
Github lost my comment that I noticed that :(
I have no idea what its doing with its life
|
I guess this needs to wait for matrix-org/synapse#4303 to land? |
|
yes, and the status of the synapse PR is waiting for the MSC bot to run its course, which it did over the holidays. |
richvdh
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See matrix-org/synapse#4303
This was done with a community hat on:
Signed-off-by: Travis Ralston travis@t2bot.io