Add better support for coverage in CI #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Nov 28, 2018
docker/synapse_sytest.sh
Outdated
| # Upload coverage to codecov, if running on CircleCI | ||
| if [ -n "$CIRCLECI" ] | ||
| then | ||
| /venv/bin/coverage combine || IGN=$? |
There was a problem hiding this comment.
Suggested change
| /venv/bin/coverage combine || IGN=$? | |
| /venv/bin/coverage combine || true |
Although, why do we want to ignore the error here and not at line 80?
There was a problem hiding this comment.
codecov doesn't return non-0 if it fails searching, only if it fails uploading
There was a problem hiding this comment.
too manynegatives I think ... this line is a search rather than an upload? So according to what you wrote, it always returns 0 here, so the || true is redundant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.