Skip to content

Add /filter to client_reader #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add /filter to client_reader #1331

merged 1 commit into from
Feb 28, 2023

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Feb 22, 2023 •
edited
Loading

Matches with matrix-org/synapse#15134.

@reivilibre reivilibre requested a review from a team as a code owner February 22, 2023 17:08
@reivilibre reivilibre mentioned this pull request Feb 22, 2023
Merged
clokep
clokep approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable from the synapse POV. Not sure if dendrite is expected to be failing?

@reivilibre
Copy link
Contributor Author

Dendrite is failing on develop, so guess so :/

@reivilibre reivilibre merged commit 169fb03 into develop Feb 28, 2023
@reivilibre reivilibre deleted the rei/filter_on_workers branch February 28, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@clokep clokep clokep approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reivilibre @clokep