Install correct extras in Synapse container at test time #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the version of extras installed at Docker build time or through explicit `pip install`s, ensure that appropriate versions of all extras are installed at test time. In particular, the url_preview (which implies lxml), postgres (which implies psycopg2) and redis extras are wanted. Signed-off-by: Sean Quah <seanq@element.io>
squahtx
commented
Mar 25, 2022
| @@ -14,14 +14,13 @@ RUN mkdir /src | |||
| # Manually upgrade pip to ensure it can locate Cryptography's binary wheels | |||
| RUN ${PYTHON_VERSION} -m venv /venv && /venv/bin/pip install -U pip | |||
| RUN /venv/bin/pip install -q --no-cache-dir matrix-synapse[all] | |||
| RUN /venv/bin/pip install -q --no-cache-dir lxml psycopg2 coverage codecov | |||
There was a problem hiding this comment.
Turns out #1219 wasn't really needed and I was just bad at reading.
DMRobertson
approved these changes
Mar 25, 2022
|
Thank you for the speedy review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the version of extras installed at Docker build time
or through explicit
pip installs, ensure that appropriate versions ofall extras are installed at test time. In particular, the url_preview
(which implies lxml), postgres (which implies psycopg2) and redis extras
are wanted.
Signed-off-by: Sean Quah seanq@element.io