Skip to content

Handle servers which send /state requests #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2022
Merged

Handle servers which send /state requests #1223

merged 3 commits into from
Mar 28, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 25, 2022

Some server implementations may make /state requests when there is a large
amount of state to sync up; add code to handle that.

@richvdh
Handle servers which send /state requests
1c1319a 
Some server implementations may make `/state` requests when there is a large
amount of state to sync up; add code to handle that.
@richvdh richvdh marked this pull request as ready for review March 25, 2022 15:04
@richvdh richvdh requested a review from a team as a code owner March 25, 2022 15:04
@squahtx squahtx self-assigned this Mar 25, 2022
squahtx
squahtx reviewed Mar 25, 2022
View reviewed changes
@squahtx squahtx removed their assignment Mar 25, 2022
@richvdh richvdh requested a review from squahtx March 28, 2022 17:29
squahtx
squahtx approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richvdh richvdh merged commit e53d72b into develop Mar 28, 2022
@richvdh richvdh deleted the rav/allow_state_requests branch March 28, 2022 18:19
This was referenced Mar 29, 2022
Closed
Merged
richvdh added a commit that referenced this pull request Mar 31, 2022
@richvdh
Accept /state reqeusts in create_outlier_event
6384373 
A follow-up to #1223: Another place that we can get `/state` requests.
@richvdh richvdh mentioned this pull request Mar 31, 2022
Merged
richvdh added a commit that referenced this pull request Mar 31, 2022
@richvdh
Accept /state requests in create_outlier_event (#1231)
81c3c06 
* Accept `/state` reqeusts in `create_outlier_event`

A follow-up to #1223: Another place that we can get `/state` requests.

* Register `/state` listeners earlier

Per comments on #1231: we ought to set up the listeners for `/state`
earlier. We also create a helper function to make it easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@squahtx squahtx squahtx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @squahtx