Let's move glob_to_regex into the tree before it vanishes from Synapse #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d3d403 to
f689b3a
Compare
f689b3a to
f411741
Compare
babolivier
approved these changes
Feb 9, 2022
| """ | ||
| # we can't use \b as it chokes on unicode. however \W seems to be okay | ||
| # as shorthand for [^0-9A-Za-z_]. | ||
| return r"(^|\W)%s(\W|$)" % (r,) |
There was a problem hiding this comment.
Note that the match isn't exactly the same with and without \b:
But not sure if that's relevant enough to care about it.
There was a problem hiding this comment.
At this stage, this is purely copy&paste from Synapse. I think we can refine later if needs be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.