Skip to content

[Backport staging] Fix: Handle parsing of a beacon info event without asset #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2022
Merged

[Backport staging] Fix: Handle parsing of a beacon info event without asset #2592

merged 1 commit into from
Aug 16, 2022

Conversation

RiotRobot
Copy link
Contributor

@RiotRobot RiotRobot commented Aug 16, 2022 •
edited by github-actions bot
Loading

Backport be3e731 from #2591.

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • [Backport staging] Fix: Handle parsing of a beacon info event without asset (#2592). Contributed by @RiotRobot.

@github-actions
Fix: Handle parsing of a beacon info event without asset (#2591)
cdb8351 
* test case

* handle missing beacon info asset

* default beacon info asset type to self

* make BeaconLocationState.assetType optional

(cherry picked from commit be3e731)
@RiotRobot RiotRobot requested a review from a team as a code owner August 16, 2022 13:33
@RiotRobot RiotRobot requested a review from germain-gg August 16, 2022 13:33
@RiotRobot RiotRobot requested review from dbkr and t3chguy August 16, 2022 13:33
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 16, 2022
@t3chguy t3chguy merged commit d18aae0 into staging Aug 16, 2022
@t3chguy t3chguy deleted the backport-2591-to-staging branch August 16, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiotRobot @dbkr @t3chguy