-
-
Notifications
You must be signed in to change notification settings - Fork 641
Closed
Description
Describe the bug
The docblock of EventTimelineSet
s constructor states that the room should be nullable, the parameters however state that it is not. Also the usage within the class is not clear how it should be used. (getPendingEvents
has a guard clause, while aggregateRelations
does not)
This leads to errors if you use the Timelineset without providing a room.
To Reproduce
Steps to reproduce the behavior:
- Create a new EventTimelineSet with room set to null
- Try to add an Event with a relation (in our case
m.replace
)
Expected behavior
The class should work correctly without a room or the docblock should be changed.
Desktop (please complete the following information):
- OS: Ubuntu
- Browser: chrome, firefox
Metadata
Metadata
Assignees
Labels
No labels