Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Dendrite includes an unspecced "room_id" field in /hierarchy response #2588

@clokep

Description

@clokep

MSC2946 dropped a room_id field from each entry in children_state, since it is redundant. This change was not properly reflected in Synapse or Dendrite.

I'm updating complement (matrix-org/complement#422) to no longer depend on this field, but Dendrite still returns it. I'm unsure if it is as simple as removing this line from gomatrixserverlib, but it seems to be an initial spot to check at least:

https://github.com/matrix-org/gomatrixserverlib/blob/a75fa15a03a00236a26744e0fc6cea20b4eb69ee/federationtypes.go#L799

Cross-linking the Synapse issue: matrix-org/synapse#10946.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions