Faster room joins: Deflake test for room stats update once synced #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can take some time for a room to appear in the public room directory after joining it, even after the request to add the room to the directory has completed. Add retry logic to check the public room directory for 3 seconds before giving up.
DMRobertson
reviewed
Feb 9, 2023
DMRobertson
approved these changes
Feb 9, 2023
|
AFAICS the Synapse flake is matrix-org/synapse#14226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can take some time for a room to appear in the public room
directory after joining it, even after the request to add the room
to the directory has completed. Add retry logic to check the public room
directory for 3 seconds before giving up.
Fixes matrix-org/synapse#15006.