Faster room joins: Deflake events-arriving-before-prev_events test #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synapse can take a while to persist 100 outliers. Instead of doing one big wait for the last outlier to be persisted, do some smaller waits for intermediate outliers and a small wait for the last outlier. ie. as long as the homeserver under test is making progress, we are happy to continue waiting.
DMRobertson
approved these changes
Oct 6, 2022
|
Thanks for the review! |
squahtx
pushed a commit
that referenced
this pull request
Feb 9, 2023
We previously attempted to deflake this test in #490 by waiting longer for the 100 outlier events to be persisted. This turned out to be insufficient, as calculating the full state for all 100 events can also take a while and delay the room's appearance in /sync. Raise the timeout for waiting for the room to appear in /sync from 5 seconds to 20 seconds. Going off the logs of the failing test runs, it takes 6 to 10 seconds for the room to appear in /sync.
squahtx
added a commit
that referenced
this pull request
Feb 9, 2023
…ain (#602) We previously attempted to deflake this test in #490 by waiting longer for the 100 outlier events to be persisted. This turned out to be insufficient, as calculating the full state for all 100 events can also take a while and delay the room's appearance in /sync. Raise the timeout for waiting for the room to appear in /sync from 5 seconds to 20 seconds. Going off the logs of the failing test runs, it takes 6 to 10 seconds for the room to appear in /sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse can take a while to persist 100 outliers. Instead of doing one big wait for the last outlier to be persisted, do some smaller waits for intermediate outliers and a small wait for the last outlier.
ie. as long as the homeserver under test is making progress, we are happy to continue waiting.
Fixes matrix-org/synapse#13777.