Skip to content

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 18, 2022

Adds some more testcases for faster joins - in particular, that we can (initial) /sync during a faster join, and that /members blocks until the resync completes.

Depends on matrix-org/synapse#12498.

Review commit-by-commit: it has a couple of refactoring commits.

richvdh added 2 commits May 18, 2022 16:39
We're going to need to do this several times for different tests, so we factor
out a separate function, and some utility methods to use the result.
richvdh added 2 commits May 18, 2022 17:13
Mostly, this is nice because it groups all the output together.
@squahtx squahtx self-assigned this May 20, 2022
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh merged commit 9013049 into main May 23, 2022
@richvdh richvdh deleted the rav/faster_joins/08_no_wait_for_filtered_state branch May 23, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants