Skip to content

Conversation

MadLittleMods
Copy link
Collaborator

@MadLittleMods MadLittleMods commented Jul 20, 2021

@MadLittleMods MadLittleMods force-pushed the madlittlemods/synapse-10432-switch-to-chunk-events branch from e3635f9 to 829839f Compare July 20, 2021 05:08
@MadLittleMods MadLittleMods requested a review from kegsay July 22, 2021 19:48
MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Jul 22, 2021
Disable msc2716 tests until both the Complement and Synapse PRs
are merged.

Currently #10432 is merged
but is still open matrix-org/complement#168
which relies on the changes.

Unfortunately, we would run into this situation if either side was merged too.
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this chunk event is made in Synapse and not by the client.

@MadLittleMods
Copy link
Collaborator Author

I assume this chunk event is made in Synapse and not by the client.

Correct, it's automatically added when using the /batch_send endpoint 👍

@MadLittleMods MadLittleMods merged commit eff9d80 into master Jul 23, 2021
@MadLittleMods
Copy link
Collaborator Author

Thanks for the review @kegsay 🐄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants