Follow upstream change to always check regular expression flags by flags
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
commented
Apr 14, 2023
| 1. Return ? RegExpExec(_rx_, _S_). | ||
| 1. Else, | ||
| 1. Assert: _global_ is *true*. |
There was a problem hiding this comment.
This assertion is no longer there upstream: https://tc39.es/ecma262/#sec-regexp.prototype-@@match
gibson042
approved these changes
Apr 14, 2023
| 1. Perform ? Set(_rx_, *"lastIndex"*, *+0*<sub>𝔽</sub>, *true*). | ||
| 1. If _flags_ contains *"u"* or _flags_ contains *"v"*, let _fullUnicode_ be *true*. Otherwise, let _fullUnicode_ be *false*. |
There was a problem hiding this comment.
Decoupling assignment of fullUnicode to no longer be conditioned on global being true reads so much better!
|
I see the CI error, but somehow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc39#2791