-
Notifications
You must be signed in to change notification settings - Fork 918
[DEV] ptable_table.json
generate with unified interface
#4338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV] ptable_table.json
generate with unified interface
#4338
Conversation
…mplify-ptable-json-generator
I want to point out that ChatGPT can make this extremely easy. I passed ChatGPT the yaml and prompted it to "separate out the units of each property for each element from the value, keeping the dictionary schema consistent". Below is the result.
|
Beautiful, thanks a ton for chiming in! That would be really helpful. I would work on this likely next week, enjoy the weekend :) |
@shyuep this PR is ready from my side, as it might be changing the core functionalities of pymatgen, I would like to push forward as slowly and carefully as possible, so I would separate the workflow into multiple steps:
|
…mplify-ptable-json-generator
a1ba60b
to
946fda0
Compare
This is merged since it only affects the dev directory. Thanks. |
No problem at all, thanks for reviewing! Yes I was trying to separate JSON generator and rewrite of JSON loader/parser for ptable.py into separate PRs. |
Summary
ptable_table.json
generation, [Proposal] Better periodic table dev recording (periodic_table.yaml
)- One property per file? #4336bvparm2011
(1d9ab4d) andperiodic_table.db
(benchmark from c80afb5)JSON/YAML generation directly from source with unified parser interface
Follow up PRs
core.periodic_table.json
core.Element
_compare_json.py
Compare new JSON with current
Save a copy of current (master branch) JSON/YAML for quick lookup (uploading YAML not allowed): master_json_yaml.zip
pymatgen/dev_scripts/periodic_table_resources/_compare_json.py