Skip to content

added JS option to $SUPPORTED_METHODS in opt out #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

reeno
Copy link
Contributor

@reeno reeno commented Sep 25, 2023

Description:

Hello,

Matomo changed the opt out from iFrame to JS, see matomo-org/matomo#17452

So the full URI has to look like this: /matomo-proxy.php?module=CoreAdminHome&action=optOutJS&divId=matomo-opt-out&language=auto&showIntro=1
But in matomo-proxy.php, only optOut is in the list of allowed methods. optOutJS has to be added or the file returns an error 404. Now both methods are supported.

Review

@sgiehl sgiehl merged commit 02d4d5c into matomo-org:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants