Skip to content

Add current PHP versions to Travis CI tests #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 25, 2022
Merged

Add current PHP versions to Travis CI tests #70

merged 5 commits into from
May 25, 2022

Conversation

pixelbrackets
Copy link
Contributor

@pixelbrackets pixelbrackets commented May 24, 2022 •
edited
Loading

Description:

Follow-Up for #71 - WIP

  • Add current PHP versions (7.4, 8.0, 8.1)

Review

@pixelbrackets pixelbrackets force-pushed the 20220524-fix-travis-tests branch from 062c6c1 to d01db7e Compare May 24, 2022 11:26
@pixelbrackets
Copy link
Contributor Author

pixelbrackets commented May 24, 2022 •
edited
Loading

I splitted the PR, since newer PHP versions are not supported by the existing test framework and throw errors. This needs additional work. So I would like to keep this open as work in progress, please merge #71 first.

@pixelbrackets pixelbrackets changed the title Fix Travics CI tests Add current PHP versions to Travics CI tests May 24, 2022
@pixelbrackets pixelbrackets changed the title Add current PHP versions to Travics CI tests WIP: Add current PHP versions to Travics CI tests May 24, 2022
sgiehl
sgiehl reviewed May 24, 2022
View reviewed changes
@pixelbrackets pixelbrackets force-pushed the 20220524-fix-travis-tests branch 2 times, most recently from b0969c0 to 351bcfe Compare May 25, 2022 06:46
@pixelbrackets
[FEATURE] Add test for new PHP versions
bfe3df0 
Use current PHP versions in tests.

Refs matomo-org#69
@pixelbrackets
[FEATURE] Add metafiles
6ed4f03 
Add .editorconfig for expected file format
Add .php-version for expected PHP version
@pixelbrackets
[FEATURE] Add Composer file
1a8c804 
Introduce Composer to the project.

Refs matomo-org#48
@pixelbrackets
[FEATURE] Move dev dependencies
913aff4 
Move dev dependencies from subfolder to main composer file.
@pixelbrackets pixelbrackets force-pushed the 20220524-fix-travis-tests branch from 351bcfe to 913aff4 Compare May 25, 2022 06:46
@pixelbrackets pixelbrackets changed the title WIP: Add current PHP versions to Travics CI tests Add current PHP versions to Travics CI tests May 25, 2022
@pixelbrackets
Copy link
Contributor Author

pixelbrackets commented May 25, 2022 •
edited
Loading

Fixed the tests for the newer versions. Now ready to merge. 🚀

@pixelbrackets pixelbrackets changed the title Add current PHP versions to Travics CI tests Add current PHP versions to Travis CI tests May 25, 2022
@pixelbrackets pixelbrackets requested a review from sgiehl May 25, 2022 09:05
sgiehl
sgiehl reviewed May 25, 2022
View reviewed changes
sgiehl
sgiehl approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Btw. at some later point we should also consider to move from travis tests to github actions. We are also preparing this for our other repos. So if you are familiar with github actions, feel free to also create a PR for that.

@sgiehl sgiehl merged commit 57cef04 into matomo-org:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixelbrackets @sgiehl