add DNT and X_DO_NOT_TRACK header support #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattab I think the tests are failing but are unrelated to the PR. Could you please have a look? Thank you. |
|
@mattab additionally the php versions which are tested seem to be outdated. there is a test for php 5.4 and 5.5 which are EOL and there are not tests for 7.1 or 7.2. I'd suppose changing the test envs to 5.6, 7.1 and 7.2 |
This was referenced Apr 5, 2018
Closed
|
I've disable the DNT specific tests again, as I now understood that the answer from piwik.php does NOT include the DNT headers, as piwik.php does only forward them to matomo without any trace in the answer, |
… with status 200 if we set the DNT headers.
|
Thanks for the PR @level420 , made a couple tweaks to it based on matt's review & merging now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #24 which adds forwarding of the DNT and X_DO_NOT_TRACK header support.
Both headers are forwarded separately which allows matomo to handle them independently.
Tests are added for both headers.