Update ecommerce tracking in etracker #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Debug Mode
Debug Mode
|
Hello everybody, how can we get this thing into the next update? |
@ben-dw Will try to review this soon and can merge this if there is no issue. |
There was a problem hiding this comment.
@ben-dw Left few comments and questions, overall the change looks like it could be merged easily.
Once the above queries are resolved, I can try to do a functional test.
Added async functions to ecommerce events. "typeof(_etracker) === "object"" is still available.
|
@AltamashShaikh Thank you for your support. I have updated translations and another ecommerce function. |
|
@ben-dw Looks good 🎉 , Thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two more functions:
Would like to hear feedback and the merge :)