Skip to content

Fix etracker Tag (Version 4) #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Fix etracker Tag (Version 4) #279

merged 5 commits into from
Oct 20, 2020

Conversation

ben-dw
Copy link
Contributor

@ben-dw ben-dw commented Oct 19, 2020

Fixed validator and cookieless tracking

Similar to matomo-org#273, just for version 4
etracker configuration is not necessary for events, only for pageview and wrapper.
Fix validator, not necessary for 'event' type.
Add data-block-cookies attribut if checked in configuration file.
@ben-dw ben-dw changed the title Fix etracker Tag Fix etracker Tag (Version 4) Oct 19, 2020
@tsteur
Copy link
Member

tsteur commented Oct 19, 2020

Hi @ben-dw do you mind fixing the merge conflicts?

@ben-dw
Copy link
Contributor Author

ben-dw commented Oct 20, 2020

Hi @tsteur, done :)

@tsteur
Copy link
Member

tsteur commented Oct 20, 2020

Thanks @ben-dw

@tsteur tsteur merged commit 3438bb8 into matomo-org:4.x-dev Oct 20, 2020
@ben-dw ben-dw deleted the patch-7 branch November 14, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants