etracker wrapper function added for single page applications compatibility #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapper function added
Added wrapper function
|
Cheers @ben-dw |
|
I'm wondering why the changelog 3.13.5 shows that this ticket is integrated. I can't see any changes in the download file for the new matomo version. |
|
That actually shouldn't be included in the changelog. It was merged to 4.x-dev branch, so it will be included in the first Matomo 4 release and not in any 3.x release. ping @mattab |
|
I think the milestone would need to be ignored here: |
|
now deleted the entries from changelog, thanks for the notice @ben-dw (also renamed the milestone to Matomo 4.0.0 so it would match my regex I had set: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added one further function of etracker (https://www.etracker.com/docs/integration-setup/tracking-code-sdks/tracking-code-integration/dynamische-inhalte-wrapper/).
This function is needed for SPA (single page applications) to trigger pageviews.