Skip to content

Fix possible error on PHP 7.4 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2020
Merged

Fix possible error on PHP 7.4 #235

merged 1 commit into from
Apr 5, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 3, 2020

Some tests are throwing errors on PHP 7.4:

Trying to access array offset on value of type bool
/home/travis/build/matomo-org/matomo/plugins/TagManager/Model/Variable.php:129

refs matomo-org/matomo#15720

@sgiehl sgiehl added this to the Current sprint milestone Apr 3, 2020
@sgiehl sgiehl requested a review from tsteur April 3, 2020 08:28
@tsteur tsteur merged commit a29c6e0 into 4.x-dev Apr 5, 2020
@tsteur tsteur deleted the php74fix branch April 5, 2020 20:34
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur Awaiting requested review from tsteur

Assignees
No one assigned
Labels
c: Tests & QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgiehl @tsteur @innocraft-automation