Added settings to configure piwik.js and piwik.php path #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31b2200 to
7f1f6b6
Compare
tsteur
reviewed
Aug 16, 2019
| $this->makeSetting('jsEndpoint', 'piwik.js', FieldConfig::TYPE_STRING, function (FieldConfig $field) { | ||
| $field->title = 'Tracker Javascript Path'; | ||
| $field->uiControl = FieldConfig::UI_CONTROL_SINGLE_SELECT; | ||
| $field->availableValues = array( |
There was a problem hiding this comment.
we'd also want matomo.js and matomo.php. Why not in general directly let users enter a value? Some rename them to say tracker.js or something else when they want to avoid ad blockers etc.
There was a problem hiding this comment.
Good point. I have added matomo.js/.php. Having a dropdown seems a bit more user friendly for not so advanced users to me. In most cases using /js/ should be good enough. I did some testing a while ago, and using /js/ for js and tracking requests was not blocked by any browser extension. If you like a free text value better, maybe it still makes sense to keep the dropdown and add something like "other" into it.
7f1f6b6 to
affc8a6
Compare
…racker.php variants)
affc8a6 to
8f64582
Compare
|
Cheers @MichaelHeerklotz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for js/ and js/tracker.php endpoints.