Added a config setting for "setDomains" (needed for cross-domain tracking) #177
Conversation
|
|
||
| $this->makeSetting('domains', '', FieldConfig::TYPE_STRING, function (FieldConfig $field) { | ||
| $field->title = 'Domains'; | ||
| $field->description = 'Set array of hostnames or domains to be treated as local. For wildcard subdomains, you can use: ".example.com" or "*.example.com". You can also specify a path along a domain: "*.example.com/subsite1"'; |
There was a problem hiding this comment.
Should the description maybe say something like comma separated list? Or how would one actually configure an array? (haven't looked what setDomains) supports
There was a problem hiding this comment.
Just checked setDomains expects an array...
btw be good to have this setting 👍
I'm not sure if we have a problem or not... haven't tried to implement it and don't know if I remember details 100% correct whether there is a problem when someone wants to define a string to read it from a TagManager Variable or when someone wants to define an array of strings. Not sure if both is actually possible at the same time yet. Not sure you understand.
There was a problem hiding this comment.
Thank you. The code is now using an array for setDomains().
I have also updated the description a bit, most of it comes from the setDomains() from https://developer.matomo.org/api-reference/tracking-javascript
31b456e to
6d77a65
Compare
|
Cheers 👍 works nicely |
This setting allows to configure the setDomains() call. Related: #160