Skip to content

Prevent error "cannot read property 'firstChild' of null" #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 24, 2019

When Custom HTML tag is set to be inserted into the body, but the tag manager is embedded in the script header and loaded and executed before the body is present in the dom, we need to wait for the body to become available.

When Custom HTML tag is set to be inserted into the body, but the tag manager is embedded in the script header and loaded and executed before the body is present in the dom, we need to wait for the body to become available.
@tsteur tsteur added this to the Current sprint milestone Jul 24, 2019
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this can't be covered in a test, correct?

@tsteur
Copy link
Member Author

tsteur commented Jul 25, 2019

Unfortunately not @diosmosis

@tsteur tsteur merged commit e65e264 into master Jul 25, 2019
@tsteur tsteur deleted the customhtmltagbodyinsert branch July 25, 2019 00:33
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants