Skip to content

Converts UI tests to headless chrome #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 17, 2019
Merged

Converts UI tests to headless chrome #163

merged 26 commits into from
Jul 17, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 18, 2019

No description provided.

@sgiehl sgiehl force-pushed the chrome-headless branch 10 times, most recently from 94a1d60 to 1c73dad Compare May 20, 2019 21:04
@sgiehl sgiehl force-pushed the chrome-headless branch 4 times, most recently from e8aca60 to 78f9bf8 Compare May 25, 2019 15:30
@sgiehl sgiehl force-pushed the chrome-headless branch from 78f9bf8 to 6dba2bf Compare May 26, 2019 20:35
@sgiehl sgiehl marked this pull request as ready for review May 31, 2019 18:15
@sgiehl sgiehl requested a review from diosmosis May 31, 2019 18:16
@sgiehl
Copy link
Member Author

sgiehl commented May 31, 2019

@diosmosis this PR is kind of ready for a review. Some of the tests are randomly failing as the height of the taken screenshots differ in one pixel in height. Tried it with different ways to take the screenshots, but that didn't help. maybe you have another idea to fix that.

@tsteur
Copy link
Member

tsteur commented Jul 3, 2019

@diosmosis do you maybe some time some day to look at this?

@diosmosis
Copy link
Member

I think I fixed the 1px difference issues, there's at least one other random failure I'm not sure about. One image fails w/ a notification error saying please supply the idContainer param (or something similar). I don't want to spend too much time on that so I will probably merge for now.

@diosmosis
Copy link
Member

@tsteur was able to get a green build for UI tests, but I can't merge PRs on this repo. Can you take a look?

@tsteur
Copy link
Member

tsteur commented Jul 17, 2019

Awesome, thanks @diosmosis . Merging now and you now have also permission to merge here. For some reason was missing there.

@tsteur tsteur merged commit 1073ea8 into master Jul 17, 2019
@tsteur tsteur deleted the chrome-headless branch July 17, 2019 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants