-
Notifications
You must be signed in to change notification settings - Fork 59
Converts UI tests to headless chrome #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94a1d60
to
1c73dad
Compare
e8aca60
to
78f9bf8
Compare
@diosmosis this PR is kind of ready for a review. Some of the tests are randomly failing as the height of the taken screenshots differ in one pixel in height. Tried it with different ways to take the screenshots, but that didn't help. maybe you have another idea to fix that. |
@diosmosis do you maybe some time some day to look at this? |
I think I fixed the 1px difference issues, there's at least one other random failure I'm not sure about. One image fails w/ a notification error saying |
@tsteur was able to get a green build for UI tests, but I can't merge PRs on this repo. Can you take a look? |
Awesome, thanks @diosmosis . Merging now and you now have also permission to merge here. For some reason was missing there. |
No description provided.