Add random id to preview url to avoid browser cache #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I reckon we should rather add no cache headers eg . Need to see where to put it best. |
tsteur
added a commit
to matomo-org/matomo
that referenced
this pull request
Jan 18, 2019
Not sure if this will work across apache versions? Tested on Apache 2.2 Prevents preview files from being cached in the browser and that always the newest version will be served. refs matomo-org/tag-manager#150
|
Created matomo-org/matomo#13977 and matomo-org/matomo-nginx#48 instead |
diosmosis
pushed a commit
to matomo-org/matomo
that referenced
this pull request
Jan 21, 2019
* Don't cache tag manager preview files Not sure if this will work across apache versions? Tested on Apache 2.2 Prevents preview files from being cached in the browser and that always the newest version will be served. refs matomo-org/tag-manager#150 * Update ServerFilesGenerator.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids having to force reload with clearing browser cache if preview changes. Only problem may be debugging is that debugging in the browser might be harder. Could be interesting having an option not to append the parameter.