Skip to content

Added Axeptio, CookieYes and OneTrust consent manager tags, #PG-3597 #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2024
Merged

Added Axeptio, CookieYes and OneTrust consent manager tags, #PG-3597 #910

merged 10 commits into from
Oct 23, 2024

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Oct 18, 2024 •
edited
Loading

Description:

Added Axeptio, CookieYes and OneTrust consent manager tags
Fixes: #PG-3597, #PG-1698

Review

snake14
snake14 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a few optional comments. Things look good overall. I didn't do full testing of each integration, but I created a tag using each new template, confirmed the UI looked good, and made sure the field validation worked.

snake14
snake14 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making suggested changes. Code looks good and local testing looks good 👍

@AltamashShaikh AltamashShaikh merged commit 581930e into 5.x-dev Oct 23, 2024
5 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-intergrate-cmp-tags branch October 23, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

@araichyk araichyk Awaiting requested review from araichyk

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14