Skip to content

Integrated Hotjar and Cookiebot tag and Clicked Data attribute variable from the MTM extended plugin, #PG-3596 #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Integrated Hotjar and Cookiebot tag and Clicked Data attribute variable from the MTM extended plugin
Fixes: #PG-3596

Review

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed that both tags loaded as expected and the data attribute variable worked as expected.

@AltamashShaikh AltamashShaikh requested a review from snake14 July 25, 2024 01:48
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and confirmed that it requires the value to be numeric 👍

@AltamashShaikh AltamashShaikh merged commit b07faa3 into 5.x-dev Jul 25, 2024
4 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-3596-mtm-extended-2 branch July 25, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants