Skip to content

Re-enabled versions view for write user to view version changes #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 17, 2024
Merged

Re-enabled versions view for write user to view version changes #794

merged 7 commits into from
May 17, 2024

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented May 16, 2024 •
edited by sgiehl
Loading

Description:

Re-enabled versions view for write user to view version changes
Fixes: #PG-3488, #793

Review

@AltamashShaikh AltamashShaikh requested a review from snake14 May 16, 2024 10:06
snake14
snake14 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Functional testing worked as expected. I can see the Versions menu item, only users with the right permissions can create/edit versions, I see the new notification when trying to edit, and users with permissions can still create/edit versions 👍

@AltamashShaikh AltamashShaikh requested a review from snake14 May 17, 2024 02:52
snake14
snake14 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Functional testing went smoothly and confirmed that the FAQ link opened as expected 👍

@AltamashShaikh AltamashShaikh merged commit 3624ed4 into 5.x-dev May 17, 2024
@AltamashShaikh AltamashShaikh deleted the PG-3488-re-enable-version-view branch May 17, 2024 03:23
@sgiehl sgiehl linked an issue May 28, 2024 that may be closed by this pull request
Support unable to debug customer issue due to publish being disabled for users without tagmanager_use_custom_templates capability #793
Closed
@sgiehl sgiehl changed the title Re-enabled versions view for write user to view version changes, #PG-3488 Re-enabled versions view for write user to view version changes May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support unable to debug customer issue due to publish being disabled for users without tagmanager_use_custom_templates capability
2 participants
@AltamashShaikh @snake14