Skip to content

Show FAQ link for click classes to support document inheritance #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2024
Merged

Show FAQ link for click classes to support document inheritance #780

merged 4 commits into from
Apr 11, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added code to show FAQ link for click classes to support document inheritance
Fixes: #PG-2691

Review

AltamashShaikh
AltamashShaikh commented Apr 9, 2024
View reviewed changes
@AltamashShaikh AltamashShaikh marked this pull request as ready for review April 9, 2024 00:59
araichyk
araichyk reviewed Apr 9, 2024
View reviewed changes
araichyk
araichyk approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@araichyk araichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my machine and the tests all pass. Just suggested an optional text change. 👍

snake14
snake14 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only had a couple optional suggestions. No issues found during functional testing 👍

snake14
snake14 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent changes look good. Everything works as expected in my local testing 👍

araichyk
araichyk approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@araichyk araichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good after the latest updates. Thank you for making that text change!

@snake14 snake14 merged commit ad3bfd4 into 5.x-dev Apr 11, 2024
@snake14 snake14 deleted the PG-2691-elem-inheritance branch April 11, 2024 21:32
@sgiehl sgiehl changed the title Added code to show FAQ link for click classes to support document inheritance Show FAQ link for click classes to support document inheritance May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araichyk araichyk araichyk approved these changes

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AltamashShaikh @araichyk @snake14