Skip to content

Add support for variables in Custom JS variable #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2023
Merged

Add support for variables in Custom JS variable #731

merged 4 commits into from
Dec 20, 2023

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Nov 27, 2023 •
edited
Loading

Description:

Added code to support variables in Custom JS variable
Fixes: #PG-3109, #212

Review

michalkleiner
michalkleiner reviewed Nov 27, 2023
View reviewed changes
@AltamashShaikh AltamashShaikh changed the title Added code to support pre configured variables, #PG-3109 Added code to support variables in Custom JS variable, #PG-3109 Nov 29, 2023
@AltamashShaikh AltamashShaikh changed the title Added code to support variables in Custom JS variable, #PG-3109 Added code to support variables in Custom JS variable Nov 29, 2023
@AltamashShaikh
Copy link
Contributor Author

for cases like var {{foo}}={{bar}} use this[{{foo}}] = {{bar}};

snake14
snake14 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I was able to output the results of a CustomJS variable which referenced another CustomJS variable without any issues.

@AltamashShaikh AltamashShaikh merged commit 600fccc into 5.x-dev Dec 20, 2023
@AltamashShaikh AltamashShaikh deleted the PG-3109-variables-cjs branch December 20, 2023 05:03
@sgiehl sgiehl changed the title Added code to support variables in Custom JS variable Add support for variables in Custom JS variable Apr 8, 2024
@snake14 snake14 mentioned this pull request May 29, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AltamashShaikh @michalkleiner @snake14