Implemented setEcommerceView #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake14
requested changes
Oct 11, 2023
Updates/5.0.0-rc4.php
Outdated
| /** | ||
| * Update for version 5.0.0-rc4. | ||
| */ | ||
| class Updates_5_0_0_rc4 extends PiwikUpdates |
There was a problem hiding this comment.
Matomo 5.0.0-rc4 has already been released. Could you please refactor this for 5.0.0-rc5?
lang/en.json
Outdated
| "MatomoTagEcommerceViewIsEcommerceView": "Is Ecommerce View", | ||
| "MatomoTagEcommerceViewIsEcommerceViewHelp": "Used to record that the current page view is an item (product) page view, or a Ecommerce Category page view. On a category page, you can set the parameter category, and set the other parameters to empty strings. Tracking Product/Category page views will allow Matomo to report on Product & Categories conversion rates (Conversion rate = Ecommerce orders containing this product or category / Visits to the product or category). Requires the Ecommerce plugin to be active.", | ||
| "MatomoTagEcommerceViewPrice": "Price", | ||
| "MatomoTagEcommerceViewPriceHelp": "Item's display price, not use in standard Matomo reports, but output in API product reports.", |
There was a problem hiding this comment.
Was this meant to say used instead of use?
snake14
reviewed
Oct 11, 2023
Updates/5.0.0-rc4.php
Outdated
| $updater->executeMigrations(__FILE__, $this->getMigrations($updater)); | ||
|
|
||
| // Migrate the MatomoConfiguration type variables to all include the newly configured fields. | ||
| $migrator = new NewVariableParameterMigrator(MatomoTag::ID, 'isEcommerceView', false); |
There was a problem hiding this comment.
Can you please update this to use NewTagParameterMigrator instead, since you're adding parameters to a Tag and not a Variable?
snake14
approved these changes
Oct 12, 2023
AltamashShaikh
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought Ecommerce support would be nice (at least to a certain extend) for the Tag Manager.
This PR focuses on the
setEcommerceViewof the Matomo Tracker.Documentation is mostly copied from the corresponding function in
piwik.js.I'll open an seperate issue about my thoughts of the other ecommerce tracking functions.
Feedback and discussion is highly appreciated 😄.