Added Emarsys tag #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
requested changes
Aug 25, 2018
There was a problem hiding this comment.
Hi,
While I haven't tested it, the tag looks good.
The image can be replaced with
<svg xmlns="http://www.w3.org/2000/svg" height="36.8" width="25.5" viewBox="0 0 25.5 36.8">
<!-- Source: https://www.emarsys.com/app/uploads/2018/05/ema_web_logos_2018_01_0-1.zip (cropped) -->
<path transform="translate(-22.8)" fill="#40877e" d="M22.8 17v-5.7L35.5 17v5.7z"/>
<path transform="translate(-22.8)" fill="#32d17e" d="M22.8 11.3L48.2 0v5.7L22.8 17z"/>
<path transform="translate(-22.8)" fill="#d9e506" d="M48.2 17v-5.7L35.5 17v5.7z"/>
<path transform="translate(-22.8)" fill="#6984d1" d="M48.2 28.4v-5.7l-19 8.5v5.7z"/>
</svg>
Template/Tag/EmarsysTag.php
Outdated
| ); | ||
| } | ||
|
|
||
| public function getOrder() |
There was a problem hiding this comment.
Until we have a significant number of different tags, I'd leave the default order and maybe order all of them afterwards.
|
@MichaelHeerklotz are you still working on this? Can I be of any help to make changes or is it considered done? |
6972bf2 to
5373245
Compare
|
Thank you for your feedback and help, I have applied the changes. |
Findus23
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Emarsys support, currently with these commands: category, view, tag, go
Use case: landing pages or similar that supplement a given shop system